Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"All-column" vis when only few columns in dataframe #199 #336

Merged
merged 45 commits into from
Apr 18, 2021
Merged

"All-column" vis when only few columns in dataframe #199 #336

merged 45 commits into from
Apr 18, 2021

Conversation

caitlynachen
Copy link
Contributor

Overview

Current-vis: "All-column" vis when only few columns in dataframe #199

Changes

If dataframe has only 2 or 3 columns, use current_vis to show an all-column visualization

Example Output

Screen Shot 2021-03-31 at 11 57 51 AM
Screen Shot 2021-03-31 at 11 57 35 AM

Caitlyn Chen added 27 commits February 16, 2021 10:34
@caitlynachen caitlynachen changed the title Allcol "All-column" vis when only few columns in dataframe #199 Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #336 (1b7cf75) into master (084cf77) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   84.39%   84.44%   +0.04%     
==========================================
  Files          51       51              
  Lines        3891     3902      +11     
==========================================
+ Hits         3284     3295      +11     
  Misses        607      607
Impacted Files Coverage Δ
lux/action/enhance.py 100.00% <ø> (ø)
lux/action/filter.py 91.66% <100.00%> (ø)
lux/core/frame.py 81.50% <100.00%> (+0.47%) ⬆️
lux/vis/Vis.py 75.59% <100.00%> (+0.14%) ⬆️
lux/vislib/matplotlib/ScatterChart.py 76.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084cf77...1b7cf75. Read the comment docs.

@caitlynachen caitlynachen force-pushed the allcol branch 2 times, most recently from 0769f25 to 89c206d Compare March 31, 2021 19:57
Caitlyn Chen added 2 commits March 31, 2021 13:09
@dorisjlee dorisjlee requested review from dorisjlee and jinimukh April 3, 2021 21:34
@dorisjlee
Copy link
Member

dorisjlee commented Apr 3, 2021 •
edited
Loading

Hi @caitlynachen, Thanks for the PR! The all-column visualization looks much better than the recommendations that we had before! This is especially true when we filter to only 2 or 3 columns in a dataframe. Here are some examples of this:

image
image

I was playing around with this feature and had a couple of suggestions on what we can do to improve this:

  • We might want to modify the text under the Current Visualization and title Current Visualization to say that the visualization is not based on the current intent, but based on all the columns in the current dataframe (Dataframe Visualization:based on all columns in the dataframe, with the text on "all columns" highlightable showing the columns involved.)

  • What happens when there is an intent set and there is an actual Current Visualization, in this case, do we hide the all-column vis? or show it as a separate tab?
    image

  • You might want to look into some of the failing tests, which is related to calling the print displays

jinimukh
jinimukh reviewed Apr 5, 2021
View reviewed changes
Copy link
Member

@jinimukh jinimukh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Maybe we can extend this feature to the entire dataframe and set a global config like small_dataframe_ok or show_all_data_columns depending on the use-case you were thinking of!

lux/core/frame.py Show resolved Hide resolved
lux/core/frame.py Outdated Show resolved Hide resolved
dorisjlee
dorisjlee requested changes Apr 13, 2021
View reviewed changes
lux/core/frame.py Outdated Show resolved Hide resolved
@dorisjlee dorisjlee merged commit d6cca26 into lux-org:master Apr 18, 2021
@dorisjlee dorisjlee mentioned this pull request Apr 23, 2021
Merged
dorisjlee added a commit that referenced this pull request Apr 30, 2021
@mantejpanesar @dorisjlee @caitlynachen
Adding support to improve temporal action to display different timesc…
ada6173 
…ales (#262)

* Add support to improve temporal action to display different timescales

* Resolve PR comments

* Add support to improve temporal action to display different timescales

* Resolve PR comments

* Reformat files using black

* "All-column" vis when only few columns in dataframe #199 (#336)

Co-authored-by: Caitlyn Chen <[email protected]>
Co-authored-by: Doris Lee <[email protected]>

* documentation and cleaning
* added notebook gallery
* update README
* removed scatterplot message in SQLExecutor
* fixed typo in SQL documentation

* update README and bump version

* bump version

* clear propagated vis data intent after PandasExecutor completes execute (#297)

* fix black to stable version

* Scalability: incorporate early pruning optimizations (#368)

* changes from perf branch to config
* added flag for turning on/off lazy maintain optimization

* merged in approx early pruning code

* increase overall sampling start and cap

* Adjust width and length criteria for early pruning vislist based on experiment results; Add warning message and test for early pruning

* black version update

* version lock on black

* * fixed sql tests (added approx to execute constructor)
* fixed sampling config test
* improved Executor documentation

* timescale feature
* adding weekday
* adding docs
* bugfix for y axis line chart export
* fixing temporal axis by adding timescale variable in Clause

Co-authored-by: Doris Lee <[email protected]>
Co-authored-by: Caitlyn Chen <[email protected]>
Co-authored-by: Caitlyn Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinimukh jinimukh jinimukh left review comments

@dorisjlee dorisjlee dorisjlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caitlynachen @dorisjlee @jinimukh